Closed
Conversation
Contributor
|
I think this is a bit overkill just to save 2 seconds, considering that the check isn't cheap either. =/ |
rata
force-pushed
the
suse-sleep-test
branch
3 times, most recently
from
7c73812 to
9b62244
Compare
Member
Author
|
I'd be surprised if that takes two seconds, tbh. But yeah, I'm not 100% convinced either. I wanted to sketch it to see how it looks and decide. |
rata
force-pushed
the
suse-sleep-test
branch
7 times, most recently
from
d1e7c47 to
e96cff7
Compare
This way we don't affect github actions and if other platforms need this in the future (unlikely), we can decide to add them on a case-by-case basis. Signed-off-by: Rodrigo Campos <rodrigoca@microsoft.com>
Contributor
|
Seems like an overkill to me; I'd rather keep things simple (in tests, at least, where we don't really care for performance). |
Member
Author
|
Fair, I'll close it. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way we don't affect github actions and if other platforms need this in the future (unlikely), we can decide to add them on a case-by-case basis.
Follow-up for: #4825.
@cyphar @kolyshkin PTAL
As I said in the PR, it looks fine to me without this too. I won't complain if you don't want to merge this